Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMake] Use PROJECT_SOURCE_DIR for nested projects. #780

Merged
merged 1 commit into from
Sep 22, 2020
Merged

[CMake] Use PROJECT_SOURCE_DIR for nested projects. #780

merged 1 commit into from
Sep 22, 2020

Conversation

marsupial
Copy link
Contributor

Using CMAKE_SOURCE_DIR here breaks when the maya-usd project is included in another parent project

@marsupial marsupial mentioned this pull request Sep 17, 2020
Closed
JGamache-autodesk
JGamache-autodesk approved these changes Sep 17, 2020
View reviewed changes
Copy link
Collaborator

@JGamache-autodesk JGamache-autodesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reading the documentation, this makes a lot of sense. Thanks!

@kxl-adsk kxl-adsk added the build Related to building maya-usd repository label Sep 17, 2020
@kxl-adsk kxl-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Sep 17, 2020
@kxl-adsk kxl-adsk merged commit cb5cecb into Autodesk:dev Sep 22, 2020
@kxl-adsk
Copy link

@marsupial Your PR is merged. Please close issue #781

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HamedSabri-adsk HamedSabri-adsk HamedSabri-adsk approved these changes

@JGamache-autodesk JGamache-autodesk JGamache-autodesk approved these changes

Assignees

@ecp-maya-devops-adsk ecp-maya-devops-adsk

Labels
build Related to building maya-usd repository ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marsupial @kxl-adsk @HamedSabri-adsk @JGamache-autodesk @ecp-maya-devops-adsk