MAYA-106376: fix undo/redo re-parenting crash due to accessing a stale prim. #772
Conversation
HamedSabri-adsk
added
ufe-usd
HamedSabri-adsk
changed the title
There was a problem hiding this comment.
Good catch! In general, any command which stores UFE scene items (or USD prims, same issue) is suspicious.
I think you should simply remove the _ufeSrcItem and _ufeDstItem data members, because they are no longer useful, and doing this would completely remove the possibility of relying on stale prims. Just use local variables where UFE scene items are needed.
| @@ -124,16 +124,20 @@ bool UsdUndoInsertChildCommand::insertChildRedo() | |||
| bool status = SdfCopySpec(_childLayer, _usdSrcPath, _parentLayer, _usdDstPath); | |||
| if (status) | |||
| { | |||
| // we shouldn't rely on UsdSceneItem to access the UsdPrim since | |||
| // it could be stale. Instead we should get the USDPrim from the Ufe::Path | |||
| const auto& desPrimUsd = ufePathToPrim(_ufeDstPath); | |||
There was a problem hiding this comment.
Same a line 164: this will give the wrong stage at line 134.
There was a problem hiding this comment.
Naming nit-pick: should use "dst" or "des" prefix for "destination", but not both.
Good point but we can't remove _ufeDstItem since it needs to be passed to insertedChild(). For now, I removed _ufeSrcItem since it serves no purpose to be stored. Addressed in c29d1e4 |
HamedSabri-adsk
added
the
ready-for-merge
This PR addresses the random undo/redo crash after performing multiple re-parenting operations.