Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make fixturesUtils.py available to all tests #759

Conversation

mattyjams
Copy link
Contributor

For the parts of mayaUsd that originated in the Pixar plugin, I'm trying to get more of the tests still orphaned in plugin/pxr migrated over to the project-level test/... area. I wanted to float this change as a way of making the fixturesUtils.py module that was previously only available to translators tests available to all Python tests.

Let me know what you think!

This change moves the fixturesUtils.py module previously local to the
translators tests up to a "project-level" testUtils directory. The contents of
the testUtils directory is installed into the following location in the build
directory:

${CMAKE_BINARY_DIR}/test/python

We then add that directory to PYTHONPATH when registering tests so that *all*
tests will have access to the Python module, and any others we choose to add
in testUtils. This avoids polluting the install directory with test-only Python
modules.
@kxl-adsk kxl-adsk requested a review from ppt-adsk September 1, 2020 13:21
@kxl-adsk kxl-adsk added the unit test Related to unit tests (both python or c++) label Sep 1, 2020
Copy link
Collaborator

@ppt-adsk ppt-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matt.

@kxl-adsk kxl-adsk merged commit e2060a8 into Autodesk:dev Sep 1, 2020
@mattyjams mattyjams deleted the pr/make_fixturesUtils_available_to_all_tests branch September 1, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unit test Related to unit tests (both python or c++)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants