[mayaUsdUI] replace #pragma once with #ifndef include guards #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattyjams
deleted the
pr/replace_mayaUsdUI_pragma_once_with_include_guards
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're finally getting our VFX platform 2019 and Maya 2020+ builds into a place where we're able to build the UI components of maya-usd, but I ended up tripping over the
#pragma oncedirectives being used there. I'm not sure exactly what the specific difference in setup is between our build internally and the CMake build, but since we landed on include guards being preferred to#pragma oncein the coding guidelines, I just converted all of the headers in mayaUsdUI.