MAYA-106032 - add new prim fails after delete #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… addition of prims of the same type * When computing unique child name we need to also consider inactive prims.
seando-adsk
commented
Aug 25, 2020
Comment on lines
+300
to
+303
| # Add a new Xform prim. | ||
| cmd = contextOps.doOpCmd(['Add New Prim', 'Xform']) | ||
| self.assertIsNotNone(cmd) | ||
| ufeCmd.execute(cmd) |
There was a problem hiding this comment.
Create a single xform prim
Comment on lines
+310
to
+313
| # Using UFE, delete this new prim (which doesn't actually delete it but | ||
| # instead makes it inactive). | ||
| cmds.pickWalk(d='down') | ||
| cmds.delete() |
There was a problem hiding this comment.
Delete that new xform (which will deactivate it)
Comment on lines
+319
to
+323
| # Add another Xform prim (which should get a unique name taking into | ||
| # account the prim we just made inactive). | ||
| cmd = contextOps.doOpCmd(['Add New Prim', 'Xform']) | ||
| self.assertIsNotNone(cmd) | ||
| ufeCmd.execute(cmd) |
There was a problem hiding this comment.
Create another xform prim - it should succeed with a unique name that considered the inactive prim
Comment on lines
+325
to
+327
| # The proxy shape should now have a single UFE child item. | ||
| self.assertTrue(proxyShapehier.hasChildren()) | ||
| self.assertEqual(len(proxyShapehier.children()), 1) |
There was a problem hiding this comment.
We should have one child (because we don't count the inactive one)
ppt-adsk
approved these changes
Aug 25, 2020
| @@ -135,7 +135,19 @@ std::string uniqueChildName(const UsdSceneItem::Ptr& usdParent, const Ufe::Path& | |||
| if (!usdParent) return std::string(); | |||
|
|
|||
| TfToken::HashSet childrenNames; | |||
| for (auto child : usdParent->prim().GetChildren()) | |||
|
|
|||
| // The prim GetChildren method used the UsdPrimDefaultPredicate which includes | |||
seando-adsk
added
bug
seando-adsk
added
the
ready-for-merge
kxl-adsk
deleted the
donnels/MAYA-106032/adding_new_prim_fails_after_delete
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAYA-106032 - Adding a prim and then deleting it no longer allows the addition of prims of the same type