adapt to refactoring in core USD of registry handling of prim specs versus prim definitions #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ange where we will replace the prim spec in SchemaAdaptor with a pointer to a UsdPrimDefinition. 1. Moving more of the code in GetSchemaByName() and ApplySchemaName() into the version separated #ifdef blocks so that it can be changed in vesion > 2002 block only. 2. SchemaAdaptor will also store the schema name token as that will not be able to be retrieved directly from a UsdPrimDefinition. 3. _GetMayaAttrNameOrAlias() takes a name instead of an attribute spec. 4. Added a static accessor, _GetAttributeSpec(), to reduce the number of places that will require USD version #ifdefs when the SchemaAdaptor is able to hold a UsdPrimDefinition. (Internal change: 2092234)
…ptor This involves converting the SchemaAdaptor to store a UsdPrimDefinition pointer instead of an SdfPrimSpecHandle while maintaining backwards compatibility with older versions of USD that don't have UsdPrimDefinition. GetSchemaPrimSpec() was removed in core USD commit PixarAnimationStudios/OpenUSD@0e3171a (Internal change: 2092250)
This identifies core USD commit 5d1771d (post 20.08 release) as the most recent supported version of USD: PixarAnimationStudios/OpenUSD@5d1771d
mattyjams
force-pushed
the
pr/prim_spec_vs_prim_definition_refactoring
branch
from
ab96615 to
fdc9e67
Compare
|
Rebased to resolve merge conflict in |
kxl-adsk
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were made by the core USD team to allow some refactoring in the schema registry. They make use of API added in core USD version 20.05 so older APIs can be removed for later versions of USD. Support for older versions of USD is maintained as well.
The changes here are required to build against core USD at commit PixarAnimationStudios/OpenUSD@0e3171a or later.