MAYA-103701 - UFE: Maya crashes after switching variant #726

seando-adsk · 2020-08-19T20:38:11Z

MAYA-103701 - UFE: Maya crashes when selecting a new object after switching variant

Removed special case for add/remove reference and instead created special case for add or delete operations. In these cases we send the UFE add/delete notifs. Otherwise we fallback and send the UFE subtree invalidate notif.
In the tests that add new prims and test delete, added a UFE observer to make sure we are getting the correct notifs.

…tching variant * Removed special case for add/remove reference and instead created special case for add or delete operations. In these cases we send the UFE add/delete notifs. Otherwise we fallback and send the UFE subtree invalidate notif. * In the tests that add new prims and test delete, added a UFE observer to make sure we are getting the correct notifs.

seando-adsk · 2020-08-19T20:39:38Z

lib/mayaUsd/ufe/private/UfeNotifGuard.h

-//! \brief Helper class to scope when we are in an add or remove reference operation.
-class InAddOrRemoveReference
+//! \brief Helper class to scope when we are in an add or delete operation.
+class InAddOrDeleteOperation


As we discussed, removed the special case for add/remove reference and instead made a special case for add/delete of prims.

seando-adsk · 2020-08-19T20:40:31Z

lib/mayaUsd/ufe/StagesSubject.cpp

-			if (prim.IsActive())
+			// Special case when we know the operation came from either
+			// the add or delete of our UFE/USD implementation.
+			if (InAddOrDeleteOperation::inAddOrDeleteOperation())


As we discussed, if we are in an add/delete prim operation, we'll send the appropriate add/delete UFE notif.

seando-adsk · 2020-08-19T20:41:41Z

lib/mayaUsd/ufe/StagesSubject.cpp

+#if UFE_PREVIEW_VERSION_NUM >= 2014
+				// According to USD docs for GetResyncedPaths():
+				// - Resyncs imply entire subtree invalidation of all descendant prims and properties.
+				// So we send the UFE subtree invalidate notif.
+				auto notification = Ufe::SubtreeInvalidate(sceneItem);
+				Ufe::Scene::notifySubtreeInvalidate(notification);
+#endif


Otherwise send the UFE subtree invalidate. Question: do we need anything for UFE < 0.2.14?

No. We only support the current Maya preview release, and it has 0.2.20. We are supposed to go back and clean out these conditionals, but we rarely have.

seando-adsk · 2020-08-19T20:42:53Z

lib/mayaUsd/ufe/UsdContextOps.cpp

@@ -135,15 +133,13 @@ class AddReferenceUndoableCommand : public Ufe::UndoableCommand

    void undo() override { 
        if (_prim.IsValid()) {
-            MayaUsd::ufe::InAddOrRemoveReference ar;


Removed special case for add/remove reference. This will still send the UFE subtree invalidate, since it will not fall into the add/delete prim case.

seando-adsk · 2020-08-19T20:44:05Z

test/lib/ufe/testContextOps.py

-
+
+        # This test requires no additional setup.
+        if self._testMethodName == 'testAddNewPrim':


The add new prim test only needs a proxy shape (not the top layer scene).

seando-adsk · 2020-08-19T20:44:30Z

test/lib/ufe/testContextOps.py

+        import mayaUsd_createStageWithNewLayer
+        mayaUsd_createStageWithNewLayer.createStageWithNewLayer()


Move here from the setup()

seando-adsk · 2020-08-19T20:45:12Z

test/lib/ufe/testContextOps.py

+        ufeObs = TestAddPrimObserver()
+        ufe.Scene.addObjectDeleteObserver(ufeObs)
+        ufe.Scene.addObjectAddObserver(ufeObs)


Use a UFE observer helper class to make sure when we add/remove prims we get the proper UFE add/delete notifs.

seando-adsk · 2020-08-19T20:45:52Z

test/lib/ufe/testDeleteCmd.py

+        # Create our UFE notification observer
+        ufeObs = TestObserver()
+        ufe.Scene.addObjectDeleteObserver(ufeObs)
+        ufe.Scene.addObjectAddObserver(ufeObs)


Same thing for the delete operation (which does the prim deactivate/activate)

seando-adsk · 2020-08-19T20:47:33Z

test/lib/ufe/testDeleteCmd.py

@@ -209,10 +263,14 @@ def testDeleteArgs(self):
        self.assertNotIn(sphereShapeName, sphereChildrenNames)
        self.assertNotIn(ball35Name, propsChildrenNames)
        self.assertNotIn(ball34Name, propsChildrenNames)
-        self.assertFalse(cmds.ls("|pSphere1|pSphereShape1"))
+        self.assertFalse(cmds.objExists("|pSphere1|pSphereShape1"))


The ls command is actually undoable. So this test wasn't really testing the undo of the cmds.delete from line 250. My new test case caught this since the notifs weren't right.

Funny thing is that objExists says its also undoable (in docs), but this case works.

Nice catch! Uh, objExists is undoable? What does that mean? It's a pure query... Maybe if you undo objExists and it returned true, the object will become an anti-matter version of itself? I'm struggling with this, I admit.

ppt-adsk

Great tests and a nice simplification. As discussed now we have guaranteed correctness regardless of whether you're using the UFE or the USD API, with finer-grained UFE semantics where possible.

ppt-adsk · 2020-08-20T02:13:48Z

lib/mayaUsd/ufe/StagesSubject.cpp

+#if UFE_PREVIEW_VERSION_NUM >= 2014
+				// According to USD docs for GetResyncedPaths():
+				// - Resyncs imply entire subtree invalidation of all descendant prims and properties.
+				// So we send the UFE subtree invalidate notif.
+				auto notification = Ufe::SubtreeInvalidate(sceneItem);
+				Ufe::Scene::notifySubtreeInvalidate(notification);
+#endif


No. We only support the current Maya preview release, and it has 0.2.20. We are supposed to go back and clean out these conditionals, but we rarely have.

ppt-adsk · 2020-08-20T02:14:21Z

lib/mayaUsd/ufe/StagesSubject.cpp

+			}
+			else
+			{
+#if UFE_PREVIEW_VERSION_NUM >= 2014


You don't need this any more, we're at 2020.

ppt-adsk · 2020-08-20T02:21:02Z

test/lib/ufe/testDeleteCmd.py

@@ -209,10 +263,14 @@ def testDeleteArgs(self):
        self.assertNotIn(sphereShapeName, sphereChildrenNames)
        self.assertNotIn(ball35Name, propsChildrenNames)
        self.assertNotIn(ball34Name, propsChildrenNames)
-        self.assertFalse(cmds.ls("|pSphere1|pSphereShape1"))
+        self.assertFalse(cmds.objExists("|pSphere1|pSphereShape1"))


Nice catch! Uh, objExists is undoable? What does that mean? It's a pure query... Maybe if you undo objExists and it returned true, the object will become an anti-matter version of itself? I'm struggling with this, I admit.

seando-adsk commented Aug 19, 2020

View reviewed changes

seando-adsk requested a review from ppt-adsk August 19, 2020 20:48

seando-adsk added bug Something isn't working ufe-usd Related to UFE-USD plugin in Maya-Usd labels Aug 19, 2020

ppt-adsk approved these changes Aug 20, 2020

View reviewed changes

kxl-adsk assigned ecp-maya-devops-adsk Aug 20, 2020

kxl-adsk added the workflows Related to in-context workflows label Aug 20, 2020

seando-adsk unassigned ecp-maya-devops-adsk Aug 20, 2020

seando-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Aug 20, 2020

kxl-adsk merged commit 4fbdf7f into dev Aug 21, 2020

kxl-adsk deleted the donnels/MAYA-103701/crash_after_switching_variant branch August 21, 2020 00:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MAYA-103701 - UFE: Maya crashes after switching variant #726

MAYA-103701 - UFE: Maya crashes after switching variant #726

seando-adsk commented Aug 19, 2020

seando-adsk Aug 19, 2020

seando-adsk Aug 19, 2020

seando-adsk Aug 19, 2020

ppt-adsk Aug 20, 2020

seando-adsk Aug 19, 2020

seando-adsk Aug 19, 2020

seando-adsk Aug 19, 2020

seando-adsk Aug 19, 2020

seando-adsk Aug 19, 2020

seando-adsk Aug 19, 2020

seando-adsk Aug 19, 2020

ppt-adsk Aug 20, 2020

ppt-adsk left a comment

ppt-adsk Aug 20, 2020

ppt-adsk Aug 20, 2020

ppt-adsk Aug 20, 2020



		# This test requires no additional setup.
		if self._testMethodName == 'testAddNewPrim':

		import mayaUsd_createStageWithNewLayer
		mayaUsd_createStageWithNewLayer.createStageWithNewLayer()

MAYA-103701 - UFE: Maya crashes after switching variant #726

MAYA-103701 - UFE: Maya crashes after switching variant #726

Conversation

seando-adsk commented Aug 19, 2020

MAYA-103701 - UFE: Maya crashes when selecting a new object after switching variant

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ppt-adsk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment