MAYA-106190 - As a user, I would like see prim type icons #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implement new ancestorNodeTypes() method on Ufe::SceneItem.
seando-adsk
commented
Aug 13, 2020
Comment on lines
+54
to
+59
| // According to the USD docs GetAllAncestorTypes() is expensive, so we keep a cache. | ||
| static std::map<TfType, std::vector<std::string>> ancestorTypesCache; | ||
| const auto iter = ancestorTypesCache.find(schemaType); | ||
| if (iter != ancestorTypesCache.end()) { | ||
| return iter->second; | ||
| } |
There was a problem hiding this comment.
Keep a cache (key'd by schema type) for faster lookup.
seando-adsk
added
enhancement
ppt-adsk
reviewed
Aug 13, 2020
* Adding test for UsdSceneItem.
|
@ppt-adsk The second after I created the pull-request I knew I was missing a test. |
ppt-adsk
approved these changes
Aug 14, 2020
seando-adsk
added
the
ready-for-merge
|
@kxl-adsk Can we merge this. My preflight has failed twice on different OSX python2 builds (once in 2020 and once in master) with test errors. The latest test failure was: |
* Rework to support previous versions (down to 19.11) of USD.
ppt-adsk
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAYA-106190 - As a user, I would like see prim type icons