Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the wrong queried value for nodeLayerStack entry. #680

Merged
merged 1 commit into from
Jul 25, 2020

Conversation

HamedSabri-adsk
Copy link
Contributor

No description provided.

@HamedSabri-adsk HamedSabri-adsk added ufe-usd Related to UFE-USD plugin in Maya-Usd workflows Related to in-context workflows labels Jul 23, 2020
@HamedSabri-adsk HamedSabri-adsk requested a review from ppt-adsk July 23, 2020 12:26
Copy link
Collaborator

@ppt-adsk ppt-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll trust you on this one... Is this something we could write an automated test for?

@HamedSabri-adsk
Copy link
Contributor Author

Thanks @ppt-adsk , Yes definitely. I have another PR coming up soon that would simplify the logic in MayaUsdUtils::layersWithContribution(const UsdPrim& prim) by leveraging the UsdPrimCompositionQueryArc utility and will be backed an automated test.

@HamedSabri-adsk HamedSabri-adsk changed the title Fix the the wrong queried value for nodeLayerStack entry. Fix the wrong queried value for nodeLayerStack entry. Jul 23, 2020
@kxl-adsk kxl-adsk merged commit e1e13c8 into dev Jul 25, 2020
@kxl-adsk kxl-adsk deleted the sabrih/fix_typo_comp_arc_utility branch July 25, 2020 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ufe-usd Related to UFE-USD plugin in Maya-Usd workflows Related to in-context workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants