Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-104876: Fix renaming a prim to something already existing crashes maya. #627

Merged
merged 3 commits into from
Jul 7, 2020

Conversation

HamedSabri-adsk
Copy link
Contributor

No description provided.

@HamedSabri-adsk HamedSabri-adsk added the core Related to core library label Jul 7, 2020
@HamedSabri-adsk HamedSabri-adsk requested a review from ppt-adsk July 7, 2020 01:01
@kxl-adsk kxl-adsk added ufe-usd Related to UFE-USD plugin in Maya-Usd workflows Related to in-context workflows and removed core Related to core library labels Jul 7, 2020
Copy link

@kxl-adsk kxl-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add regression test.

@HamedSabri-adsk
Copy link
Contributor Author

@ppt-adsk @kxl-adsk please see c31a27c

@HamedSabri-adsk HamedSabri-adsk requested a review from kxl-adsk July 7, 2020 17:27
Copy link

@kxl-adsk kxl-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you @HamedSabri-adsk

@kxl-adsk
Copy link

kxl-adsk commented Jul 7, 2020

Failing test is unrelated to this change and only visible in our internal Maya build. This PR is good to merge.

@kxl-adsk kxl-adsk merged commit c800982 into dev Jul 7, 2020
@kxl-adsk kxl-adsk deleted the sabrih/MAYA-104876/fix_maya_crash_rename branch July 7, 2020 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ufe-usd Related to UFE-USD plugin in Maya-Usd workflows Related to in-context workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants