export UV sets as USD Texture Coordinate value types by default #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See the usd-interest thread here for a bit more discussion and context: |
HamedSabri-adsk
added
core
HamedSabri-adsk
approved these changes
Jul 1, 2020
There was a problem hiding this comment.
Makes sense to me! Thanks.
There are bunch of other places where we are still writing out UVs as float2, could you also apply the same changes for them for sake of consistency?
test/lib/ufe/test-samples/cylinder/cylinder.usda
test/lib/ufe/test-samples/parentCmd/simpleHierarchy.usda
test/lib/ufe/test-samples/parentCmd/simpleSceneTRS.usda
test/lib/ufe/test-samples/sphereAnimatedRadius/sphereAnimatedRadius.usda
test/lib/usd/translators/UsdImportCameraTest/UsdImportCameraTest.usda
test/lib/usd/translators/UsdImportFrameRangeTest/MovingCube.usda
test/lib/usd/translators/UsdImportSessionLayerTest/Cubes.usda
test/lib/usd/translators/UsdImportShadingModeDisplayColor/RedCube.usda
test/lib/usd/translators/UsdImportShadingModePxrRis/MarbleCube.usda
|
@mattyjams Thank you! |
This change flips the default value of the PIXMAYA_WRITE_UV_AS_FLOAT2 env setting variable so that UV sets export to USD as texCoord2f-typed instead of float2-typed. The resulting values are handled the same by consumers but the additional context about the role of the value's type can provide some useful information for DCCs and pipelines. The old behavior of exporting UV sets as float2-typed can be restored by setting the environment variable PIXMAYA_WRITE_UV_AS_FLOAT2 to true.
mattyjams
force-pushed
the
pr/export_UV_sets_as_TexCoord_by_default
branch
from
4844130 to
0c0ebae
Compare
Done. Rebased the change and replaced |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change flips the default value of the
PIXMAYA_WRITE_UV_AS_FLOAT2env setting variable so that UV sets export to USD astexCoord2f-typed instead offloat2-typed. The resulting values are handled the same by consumers but the additional context about the role of the value's type can provide some useful information for DCCs and pipelines.The old behavior of exporting UV sets as
float2-typed can be restored by setting the environment variablePIXMAYA_WRITE_UV_AS_FLOAT2totrue.