Add support for outline selection hilighting and disabling color-quantization #469
Conversation
| template <typename T> | ||
| void _CreateNumericAttribute( | ||
| MFnDependencyNode& node, const TfToken& attrName, MFnNumericData::Type type, | ||
| typename std::enable_if<std::is_pod<T>::value, T>::type defValue) { |
There was a problem hiding this comment.
Definitely approve of this addition (and the usage of enable_if!)
| #endif | ||
| #if USD_VERSION_NUM >= 1911 | ||
| R"mel( | ||
| attrControlGrp -label "Enable color quantization" -attribute "defaultRenderGlobals.mtohColorQuantization" -changeCommand $cc; |
There was a problem hiding this comment.
Maybe change this to "Enable color quantization for selection-coloring", since that's a bit more descriptive.
Alternatively... I'd be fine if we didn't even make this an option, and just left it always off.
There was a problem hiding this comment.
The color quantization is on the frame buffer as a whole, it just happens to run in the 'colorizeTask'.
There was a problem hiding this comment.
Oh, really? Yuck... maybe I'm not understanding what this is doing, or why it's there, then - my knowledge of color science / color management is limited. But I'm not sure in what situations you'd want this on...?
There was a problem hiding this comment.
It does two things, a quantization/dithering (so that banding is less apparent) and conversion from linear->sRGB.
I imagine tying into Maya's color-management will eventually be the way to handle such things, but until then I'd like an easy way to make sure this is off.
There was a problem hiding this comment.
We maintain compatibility with older versions of USD as stated in https://github.com/Autodesk/maya-usd/blob/dev/doc/build.md#2-download-and-build-pixar-usd.
Your PR is failing to compile with USD 19.11 with the following error
\lib\mayaUsd\render\mayaToHydra\renderOverride.cpp(461): error C2039: 'SetColorizeQuantizationEnabled': is not a member of 'pxrInternal_v0_19__pxrReserved__::HdxTaskController'
Please fix it.
marsupial
force-pushed
the
PR/mtoh-settings
branch
from
6083350 to
f8d6f53
Compare
|
Fixed....Must have back ported that into our 19.11 |
…owser_ux HYDRA 480 - add title to browser, make it stay in front of Maya main …
Outline hi-lighting was added in 22.05, and color-quantization can make things extremely slow.