EMSUSD-1783 support append export of animated values #4139
Closed
+197
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Feb 28, 2025
pierrebai-adsk
commented
- Combine values from multiple sources instead of creating new transform data channels when a transformation op already exists.
- This allows appending new animated values to an existing USD file.
- This also avoid breaking rig and skeleton which can combine multiple values when controlling a joint.
- Add a unit test for append-mode export with multiple animation frames.
- Adjust one unit test that expected additional transform channel: now it gets all values in the same normal transform op.
- Improve the error message for the unit test transform comparison helper function.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-1783/append-export
branch
from
31a4578 to
99835cb
Compare
- Combine values from multiple sources instead of creating new transform data channels when a transformation op already exists. - This allows appending new animtaed values to an existing USD file. - This also avoid breaking rig and skeleton which can combine multiple values when controlling a joint. - Add a unit test for append-mode export with multiple animation frames. - Adjust one unit test that expected additional trasnform channel: now it gets all values in the same normal transform op. - Improve the error message for the unti test transform comparison helper function. - Make compatible with older USD versions.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-1783/append-export
branch
from
99835cb to
a101bcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.