-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EMSUSD-1626 : Support MaterialX document in USD Exporter #4107
EMSUSD-1626 : Support MaterialX document in USD Exporter #4107
Conversation
Test that validate an export of MaterialXStack with surfaceshader and displacement
lib/usd/translators/shading/mtlxMaterialXSurfaceShaderWriter.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good. I would say 99% done. Sadly there are a few corner cases in MaterialX that need to be handled correctly. I have described the ones I encountered in the past.
lib/usd/translators/shading/mtlxMaterialXSurfaceShaderWriter.cpp
Outdated
Show resolved
Hide resolved
lib/usd/translators/shading/mtlxMaterialXSurfaceShaderWriter.cpp
Outdated
Show resolved
Hide resolved
lib/usd/translators/shading/mtlxMaterialXSurfaceShaderWriter.cpp
Outdated
Show resolved
Hide resolved
lib/usd/translators/shading/mtlxMaterialXSurfaceShaderWriter.cpp
Outdated
Show resolved
Hide resolved
Generalize output name handling to accomodate the special cases. Handle more input meta data. Add test case for artistic_ior (multi output node) Rework test structure to use mtlx files instead of a maya file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing the work! Looks good to me now.
ShaderWriter for the LookdevX MaterialXStack material.
Test that validate an export of MaterialXStack with surfaceshader and displacement