EMSUSD-1258 extend the delete cmd edit routing #3747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new code for doing edit routing using an edit target directly was not supporting the usual use-case of providing the target by the layer identifier or layer handle. It also always allowed stronger opinions, even though we only need it if the target is within a reference or payload. This fixes both issues: delete can now be routed like other commands by ID or layer handle and will only allow stronger opinions when targeting a non-local layer. Extending using an edit target directly in all other commands will be done separatey in the future.
|
@NickWu This enhance the PR that you opened related to targeting non-local layers for the delete command. The unit test that you added still passes, so I believe this is a pure backward-compatible enhancement. |
NickWu
reviewed
May 3, 2024
This looks good to me. Thanks. |
AramAzhari-adsk
approved these changes
May 3, 2024
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
added
ufe-usd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new code for doing edit routing using an edit target directly was not supporting the usual use-case of providing the target by the layer identifier or layer handle.
It also always allowed stronger opinions, even though we only need it if the target is within a reference or payload.
This fixes both issues: delete can now be routed like other commands by ID or layer handle and will only allow stronger opinions when targeting a non-local layer.
Extending using an edit target directly in all other commands will be done separately in the future.