Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMSUSD-1111 Edit routing for transform commands #3746

Merged
merged 1 commit into from
May 6, 2024

Conversation

pierrebai-adsk
Copy link
Collaborator

@pierrebai-adsk pierrebai-adsk commented May 1, 2024

Add helpers to support permissions and routing:

  • Provide a helper function to check permission-to-edit in the base class of the USD implementation of the UFE 3D Transform interface.
  • The helper ensures that the correct edit context is used when checking permissions.

Use helpers in transforms and commands:

  • Use those helper functions to check for permission to edit in command creation.
  • Use those helper functions to do the edits, in command execution.
  • Add edit routing context in all transform-related edits function.
  • This context queries and sets where the edits should be routed.
  • In particular, it is used in the execute, undo, redo and set functions of the command base class.
  • Properly check permissions for matrix commands.
  • The common API, 3d Matrix Op, point instances and Maya Xform stack are done.

Permissions for point instance transform

  • Make the getAttribute function of the point instance modifier base class be public.
  • Same for its derived classes.
  • Add helper function to check permission for point instances.
  • Use it to check permissions for point instances.

Add unit tests for transform routing.

@pierrebai-adsk pierrebai-adsk added the adsk Related to Autodesk plugin label May 1, 2024
@pierrebai-adsk pierrebai-adsk force-pushed the bailp/EMSUSD-1111/transform-edit-routing branch from b41f145 to e47d792 Compare May 1, 2024 20:48
@pierrebai-adsk pierrebai-adsk self-assigned this May 1, 2024
Add helpers to support permissions and routing:
- Provide a helper function to check permission-to-edit in the base class of the USD implementation of the UFE 3D Transform interface.
- The helper ensures that the correct edit context is used when checking permissions.

Use helpers in transforms and commands:
- Use those helper functions to check for permission to edit in command creation.
- Use those helper functions to do the edits, in command execution.
- Add aedit touting context in all transform-related edits function.
- This context queries and sets where the edits should be routed.
- In particular, it is used in the execute, undo, redo and set functions of the command base class.
- Properly check permissions for matrix commands.
- The common API, 3d Matrix Op, point instances and Maya Xform stack are done.

Permissions for point instance transform
- Make the getAttribute function of the point instance modifier base class be public.
- Same for its derived classes.
- Add helper function to check permission for point instances.
- Use it to check permissions for point instances.

Add unit tests for transform routing.
@pierrebai-adsk pierrebai-adsk force-pushed the bailp/EMSUSD-1111/transform-edit-routing branch from e47d792 to 1279ce9 Compare May 2, 2024 13:10
Copy link
Collaborator

@AramAzhari-adsk AramAzhari-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@pierrebai-adsk pierrebai-adsk added the ready-for-merge Development process is finished, PR is ready for merge label May 3, 2024
@seando-adsk seando-adsk added ufe-usd Related to UFE-USD plugin in Maya-Usd and removed adsk Related to Autodesk plugin labels May 6, 2024
@seando-adsk seando-adsk merged commit 37fc76a into dev May 6, 2024
11 checks passed
@seando-adsk seando-adsk deleted the bailp/EMSUSD-1111/transform-edit-routing branch May 6, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge ufe-usd Related to UFE-USD plugin in Maya-Usd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants