-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EMSUSD-1111 Edit routing for transform commands #3746
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b41f145
to
e47d792
Compare
Add helpers to support permissions and routing: - Provide a helper function to check permission-to-edit in the base class of the USD implementation of the UFE 3D Transform interface. - The helper ensures that the correct edit context is used when checking permissions. Use helpers in transforms and commands: - Use those helper functions to check for permission to edit in command creation. - Use those helper functions to do the edits, in command execution. - Add aedit touting context in all transform-related edits function. - This context queries and sets where the edits should be routed. - In particular, it is used in the execute, undo, redo and set functions of the command base class. - Properly check permissions for matrix commands. - The common API, 3d Matrix Op, point instances and Maya Xform stack are done. Permissions for point instance transform - Make the getAttribute function of the point instance modifier base class be public. - Same for its derived classes. - Add helper function to check permission for point instances. - Use it to check permissions for point instances. Add unit tests for transform routing.
e47d792
to
1279ce9
Compare
pierrebai-adsk
commented
May 2, 2024
pierrebai-adsk
commented
May 2, 2024
pierrebai-adsk
commented
May 2, 2024
pierrebai-adsk
commented
May 2, 2024
pierrebai-adsk
commented
May 2, 2024
AramAzhari-adsk
approved these changes
May 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-for-merge
Development process is finished, PR is ready for merge
ufe-usd
Related to UFE-USD plugin in Maya-Usd
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add helpers to support permissions and routing:
Use helpers in transforms and commands:
Permissions for point instance transform
Add unit tests for transform routing.