EMSUSD-1030 - Persist the default prim selection if its available #3705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelliu-adsk
commented
Apr 9, 2024
| int $count = 1; | ||
| for($item in $allItems){ | ||
| string $labelText = `menuItem -query -label $item`; | ||
| if($labelText == $defaultPrimName){ |
There was a problem hiding this comment.
Select the prim as default prim if it's in the candidates' list.
seando-adsk
reviewed
Apr 9, 2024
| for($item in $allItems){ | ||
| string $labelText = `menuItem -query -label $item`; | ||
| if($labelText == $defaultPrimName){ | ||
| optionMenuGrp -e -select $count exportDefaultPrim; |
There was a problem hiding this comment.
Here you could use optionMenuGrp -e -value $defaultPrimName exportDefaultPrim;
to set the menu item by value. Then you don't need to keep track of the count.
You could even just wrap that command in a catchQuiet then you don't even need to check if its in the menus. It will just silently fail if its not present anymore.
There was a problem hiding this comment.
Oh thanks! That should be a much better way to do it
…lliu-adsk/EMSUSD-1030/persist_default_prim
seando-adsk
approved these changes
Apr 10, 2024
samuelliu-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.