Fixup UFE_PREVIEW_NUM to use better Ufe cmake checks. #3673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ufe::Material::hasMaterial * ContextOps: kIsOptionBox Fix UINodeGraphNode tests to check specific env var (not preview num)
seando-adsk
commented
Mar 21, 2024
AramAzhari-adsk
previously approved these changes
Mar 21, 2024
seando-adsk
added
ufe
seando-adsk
commented
Mar 22, 2024
| @@ -68,6 +68,8 @@ if(UFE_INCLUDE_DIR AND EXISTS "${UFE_INCLUDE_DIR}/ufe/ufe.h") | |||
| # Temporary. Once next Maya PR is released with UFE v5.0.0 this should | |||
| # be removed (along with all the UFE_PREVIEW_VERSION_NUM checks). | |||
| set(UFE_PREVIEW_VERSION_NUM 5017) | |||
| elseif(UFE_VERSION VERSION_EQUAL "5.1.0") | |||
There was a problem hiding this comment.
I had "VERIFY_EQUAL" here - must have been an autocomplete error.
seando-adsk
commented
Mar 22, 2024
AramAzhari-adsk
approved these changes
Mar 22, 2024
seando-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixup UFE_PREVIEW_NUM to use better Ufe cmake checks.