Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMSUSD-801 - Add the feature to set the root prim type on export #3630

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

samuelliu-adsk
Copy link
Collaborator

  • Deprecate the flag parentScope and replace with rootPrim
  • Add flag rootPrimType to set the desired root prim type
  • Root Prim Type drop down on export window

@samuelliu-adsk samuelliu-adsk added import-export Related to Import and/or Export adsk Related to Autodesk plugin labels Feb 23, 2024
@samuelliu-adsk samuelliu-adsk self-assigned this Feb 23, 2024
@samuelliu-adsk samuelliu-adsk changed the title EMSUSD-901 - Add the feature to set the root prim type on export EMSUSD-801 - Add the feature to set the root prim type on export Feb 23, 2024
@samuelliu-adsk samuelliu-adsk force-pushed the samuelliu-adsk/EMSUSD-801/root_prim_type branch from e8e8246 to 5c35a82 Compare February 23, 2024 01:50
textFieldGrp -l `getMayaUsdString("kExportRootPrimLbl")` -placeholderText `getMayaUsdString("kExportRootPrimPht")`
-annotation `getMayaUsdString("kExportRootPrimAnn")` -textChangedCommand "onExportRootPrimChanged" rootPrimField;

optionMenuGrp -l `getMayaUsdString("kExportRootPrimTypeLbl")` rootPrimTypePopup;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Root Prim type section

@samuelliu-adsk samuelliu-adsk marked this pull request as ready for review February 23, 2024 02:32
Copy link
Collaborator

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, just one minor question.

| `-parentScope` | `-psc` | string | none | Name of the USD scope that is the parent of the exported data |
| `-parentScope` | `-psc` | string | none | Deprecated. Use `-rootPrim` instead. Name of the USD scope that is the parent of the exported data |
| `-rootPrim` | `-rpm` | string | none | Name of the USD root prim that is the parent of the exported data |
| `-rootPrimType` | `-rpt` | string | none | Name of the USD scope that is the parent of the exported data |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really "Name of the USD scope"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops forgot to change this

@samuelliu-adsk samuelliu-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Feb 27, 2024
@seando-adsk seando-adsk merged commit bc25569 into dev Feb 28, 2024
11 checks passed
@seando-adsk seando-adsk deleted the samuelliu-adsk/EMSUSD-801/root_prim_type branch February 28, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adsk Related to Autodesk plugin import-export Related to Import and/or Export ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants