EMSUSD-987 undo edit prototype #3593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Editing as Maya an instanced object and then undoing the edit-as-Maya would crash. That was because when editing an instance, Maya nodes were briefly created for the prototype, registered as newly-created nodes, then immediately deleted. When undoing, the undo was trying to delete those non-existing nodes. Fix by removing the deleted node from the map of created Maya nodes.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-987/undo-edit-prototype-crash
branch
from
717998d to
b1a164f
Compare
samuelliu-adsk
approved these changes
Feb 5, 2024
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
added
workflows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Editing as Maya an instanced object and then undoing the edit-as-Maya would crash. That was because when editing an instance, Maya nodes were briefly created for the prototype, registered as newly-created nodes, then immediately deleted. When undoing, the undo was trying to delete those non-existing nodes.
Fix by removing the deleted node from the map of created Maya nodes.