EMSUSD-767 - Set the default prim on export #3572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelliu-adsk
added
adsk
samuelliu-adsk
force-pushed
the
samuelliu-adsk/EMSUSD-767/set_default_prim_on_export
branch
from
19ddfc9 to
7994bc8
Compare
samuelliu-adsk
commented
Jan 24, 2024
samuelliu-adsk
commented
Jan 24, 2024
samuelliu-adsk
commented
Jan 24, 2024
samuelliu-adsk
commented
Jan 24, 2024
seando-adsk
requested changes
Jan 24, 2024
samuelliu-adsk
force-pushed
the
samuelliu-adsk/EMSUSD-767/set_default_prim_on_export
branch
from
b78dd32 to
d3a7c96
Compare
seando-adsk
previously approved these changes
Jan 24, 2024
samuelliu-adsk
added
ready-for-merge
seando-adsk
reviewed
Jan 25, 2024
| @@ -251,7 +251,7 @@ proc string mayaUsdTranslatorExport_AppendFromTextField(string $currentOptions, | |||
| return $currentOptions + ";" + $arg + "=" + $value; | |||
| } | |||
|
|
|||
| proc updateDefaultPrimList() { | |||
| global proc updateDefaultPrimList() { | |||
There was a problem hiding this comment.
This should probably be prepended with mayaUsdTranslatorExport_ like the others to avoid clashing with another global proc.
seando-adsk
approved these changes
Jan 26, 2024
samuelliu-adsk
added
the
ready-for-merge
seando-adsk
deleted the
samuelliu-adsk/EMSUSD-767/set_default_prim_on_export
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.