EMSUSD-65 wait cursor during long VP2 updates #3563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a command may trigger a long viewport update, set a flag so that the proxy render delegate shows the wait cursor while it is updating the viewport data. We make the assumption that long-duration commands will generally cause long-duration viewport updates. This is done via the already-existing LongDurationCommand base class and wait cursor functions. - Modify the WaitCursor helper class to take a flag to control if the cursor is shown or not. - This allows conditionallly showing the wait cursor based on a condition. - Add a function to tell the render delegate that it should expect its update to take a long time. - Make the wait cursor function used by long-duration commands tell the render delegate to expect a long update.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-65/long-update-wait-cursor
branch
from
7045caf to
a9c69e3
Compare
AramAzhari-adsk
approved these changes
Jan 18, 2024
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
reviewed
Jan 19, 2024
| void mayaStartWaitCursor() { MGlobal::executeCommand("waitCursor -state 1"); } | ||
| void mayaStartWaitCursor() | ||
| { | ||
| ProxyRenderDelegate::setLongDurationRendering(); |
There was a problem hiding this comment.
When code somewhere creates a WaitCursor, it always sets the long duration. What happens if the action that used the wait cursor doesn't up in ProxyRenderDelegate::update()? The long duration flag will still be set.
There was a problem hiding this comment.
Any non-trivial modification to USD will trigger an update of the render delegate. If somehow we get into that situation, at worst the next update will show the wait cursor, which is benign. I just wanted to avoid toggling the wait cursor in all render delegate updates since showing the cursor requires calling commands.
seando-adsk
approved these changes
Jan 19, 2024
seando-adsk
added
vp2renderdelegate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a command may trigger a long viewport update, set a flag so that the proxy render delegate shows the wait cursor while it is updating the viewport data. We make the assumption that long-duration commands will generally cause long-duration viewport updates. This is done via the already-existing LongDurationCommand base class and wait cursor functions.