Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EMSUSD-917 : Add a stable library as a subset of MayaUSD LIbrary call… #3555

Merged
merged 11 commits into from
Jan 31, 2024
Merged

EMSUSD-917 : Add a stable library as a subset of MayaUSD LIbrary call… #3555

merged 11 commits into from
Jan 31, 2024

Conversation

lanierd-adsk
Copy link
Collaborator

…ed mayaUsdAPI Library for maya-hydra, Bifrost etc.

@lanierd-adsk
EMSUSD-917 : Add a stable library as a subset of MayaUSD LIbrary call…
1d6ac79 
…ed mayaUsdAPI Library for maya-hydra, Bifrost etc.
@lanierd-adsk lanierd-adsk self-assigned this Jan 15, 2024
@lanierd-adsk lanierd-adsk added adsk Related to Autodesk plugin mayaHydra Related to Maya to Hydra plugin labels Jan 15, 2024
@lanierd-adsk
Copy link
Collaborator Author

FYI : @ppt-adsk , @lilike-adsk , @roopavr-adsk , @debloip-adsk

seando-adsk
seando-adsk previously approved these changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work David!

ppt-adsk
ppt-adsk requested changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@ppt-adsk ppt-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Minor suggestions here and there. One change to proxyStage.cpp is a requirement (no explicit version in namespace).

I would encourage you to think about throwing an exception in the ProxyStage constructor and avoid zombie object complexities. I will let you decide on that one.

ppt-adsk
ppt-adsk reviewed Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@ppt-adsk ppt-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good that we got to the bottom of the unique_ptr issue, thanks for that.

seando-adsk
seando-adsk requested changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the variable/method naming doesn't follow our coding stanard.

ppt-adsk
ppt-adsk requested changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@ppt-adsk ppt-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor point with an out of date comment, but otherwise looks good! Thanks for the changes!

ppt-adsk
ppt-adsk previously approved these changes Jan 19, 2024
View reviewed changes
seando-adsk
seando-adsk previously approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. There is just the one comment about the duplicated string(s) in proxyStage.cpp if you want to fix that.

@lanierd-adsk lanierd-adsk added ready-for-merge Development process is finished, PR is ready for merge and removed ready-for-merge Development process is finished, PR is ready for merge labels Jan 22, 2024
@lanierd-adsk lanierd-adsk dismissed stale reviews from seando-adsk and ppt-adsk via 1fa847c January 22, 2024 15:52
seando-adsk
seando-adsk approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Thanks for all the hard work.

@lanierd-adsk lanierd-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Jan 23, 2024
@seando-adsk seando-adsk merged commit 3c741be into dev Jan 31, 2024
11 checks passed
@seando-adsk seando-adsk deleted the lanierd/EMSUSD-917 branch January 31, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppt-adsk ppt-adsk ppt-adsk approved these changes

@seando-adsk seando-adsk seando-adsk approved these changes

Assignees

@lanierd-adsk lanierd-adsk

Labels
adsk Related to Autodesk plugin mayaHydra Related to Maya to Hydra plugin ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lanierd-adsk @ppt-adsk @seando-adsk