EMSUSD-499 - Dirty layers don't get saved in Maya files #3418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1589,7 +1589,7 @@ bool MayaUsdProxyShapeBase::isStageIncoming() const | |||
|
|
|||
| // Check what is the cache connected to | |||
| MStringArray result; | |||
| MGlobal::executeCommand(("listConnections -shapes on " + this->name()), result); | |||
| MGlobal::executeCommand(("listConnections -t shape -shapes on " + this->name()), result); | |||
|
|
|||
There was a problem hiding this comment.
Is there any reason why you did not choose to go with the solution that was suggested on github? I would like to understand why that solution was not correct? The suggestion was:
bool isIncomingStage = false;
if (!inDataHandle.data().isNull()) {
isIncomingStage = true;
}
There was a problem hiding this comment.
Hi @pierrebai-adsk , the reason is stated in the description. So if we remove the else part and leave it like this it will not work properly for Bifrost. For some reason (I get the conclusion from debugging), inDataHandle can still be Null even if we have Bifrost shape connected to it. In that case, we need to check the stage Cache and find the Bifrost shape in Cache. Hence the else part.
pierrebai-adsk
approved these changes
Oct 27, 2023
samuelliu-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for previous PR: #3402
Github issue: #3243
Adding
-t shapeto the command will exclude the "time" nodes but leave only Bifrost nodes.Deleting the
elsepart will not work because for Bifrost to save properly we will need to check for cache