Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMSUSD-287 - Setup preference section #3343

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

seando-adsk
Copy link
Collaborator

EMSUSD-287 - USD preference section

  • New MEL file "mayaUsd_preferenceTab.mel" containing the USD preference dialog code. Added when mayaUsdPlugin is loaded.
  • Removed "saving usd files" options from LayerEditor and move them to USD preferences.
  • New optionVar for Image relative.
  • For LE bulk saveas, set the initial state of relative checkboxes from optionVars.
  • In LE fixed initial dialog size.

* New MEL file "mayaUsd_preferenceTab.mel" containing the
  USD preference dialog code. Added when mayaUsdPlugin is loaded.
* Removed "saving usd files" options from LayerEditor
  and move them to USD preferences.
* New optionVar for Image relative.
* For LE bulk saveas, set the initial state of relative
  checkboxes from optionVars.
* In LE fixed initial dialog size.
@seando-adsk seando-adsk added enhancement New feature or request workflows Related to in-context workflows labels Sep 21, 2023
register("kdotusdFileFormat", ".usd File Format:");
register("kAscii", "ASCII");
register("kBinary", "Binary");
register("kSaveLayerUsdFileFormatAnn", "Select whether the .usd file is written out in binary or ASCII. You can save a file in .usdc (binary) or .usda (ASCII) format. Manually entering a file name with an extension overrides the selection in this preference.");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this comes Anisha, but to me it reads better if "You can save" is replaced with "You can also save", otherwise I feel there is a missing continuity between the two sentences.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that it did initially come from Anisha. These particular strings were just moved here from the LayerEditor string resources. So they are not new strings.

Copy link
Collaborator

@pierrebai-adsk pierrebai-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@seando-adsk seando-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Sep 25, 2023
@seando-adsk seando-adsk merged commit ce7fc17 into dev Sep 25, 2023
@seando-adsk seando-adsk deleted the donnels/EMSUSD-287/usd_preference_section branch September 25, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready-for-merge Development process is finished, PR is ready for merge workflows Related to in-context workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants