EMSUSD-80 avoid creating an extra transform when in a prototype #3315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Sep 7, 2023
pierrebai-adsk
commented
- When in a prototype, do not create an extra transform node.
- Adjust the related import tests, which were already mentioning those extra nodes.
- When in a prototype, do not create an extra transform node. - Don't add 'Shape' to the shape name. - Adjust the related import tests, which were already mentioning those extra nodes.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-80/import-extra-shape-node
branch
from
04278f2 to
b5bf69d
Compare
pierrebai-adsk
commented
Sep 7, 2023
| sel = om.MGlobal.getSelectionListByName(node) | ||
| except Exception: | ||
| self.assertTrue(False, 'Could not find node %s' % node) | ||
| self.assertEqual(sel.length(), 1, 'Could not find node %s' % node) |
There was a problem hiding this comment.
The goal of this change is to get a better error message on test failure.
|
Only failure is one PF that lost connection after all tests ran and succeeded, so I'm marking this as ready for merge. |
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.