EMSUSD-255 Fixes an issue in Layer Editor where Save All icon was not functioning properly. #3222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… functioning properly.
AramAzhari-adsk
added
bug
AramAzhari-adsk
commented
Jul 12, 2023
| QLayout* anonLayout = _anonLayersWidget->layout(); | ||
| for (int i = 0, count = anonLayout->count(); i < count; ++i) { | ||
| auto row = dynamic_cast<SaveLayerPathRow*>(anonLayout->itemAt(i)->widget()); | ||
| for (int i = 0, count = _saveLayerPathRows.size(); i < count; ++i) { |
There was a problem hiding this comment.
I kept the order of iteration the same as before, Although in this case it shouldn't matter as it is only picking one item.
AramAzhari-adsk
commented
Jul 12, 2023
| QLayout* anonLayout = _anonLayersWidget->layout(); | ||
| for (int i = 0, count = anonLayout->count(); i < count; ++i) { | ||
| func(anonLayout->itemAt(i)->widget()); | ||
| for (int i = 0, count = _saveLayerPathRows.size(); i < count; ++i) { |
There was a problem hiding this comment.
Same here, the order of iteration is from top layer to bottom
seando-adsk
approved these changes
Jul 17, 2023
AramAzhari-adsk
added
the
ready-for-merge
seando-adsk
deleted the
azharia/EMSUSD-255/Fixes-LayerEditor-SaveAll-Functionality
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EMSUSD-255 Fixes an issue in Layer Editor where Save All icon was not functioning properly.
The issue occurred due to Qt UI layout changes. The solution is to keep track of the SaveLayerPathRow data separately so that it can be iterated over when saving all layers.