MAYA-127770 missing discard edits #3154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrebai-adsk
added
bug
AramAzhari-adsk
previously approved these changes
Jun 13, 2023
pierrebai-adsk
added
ready-for-merge
After editing-as-Maya and then deleting teh stage, the menu for discard edit would not show up or would do nothing. Fix this by correctly updating the pulled information on the Maya node. - Correctly compute the new pulled path in the case where the stage proxy node no longer exists. - This happens because as part of deletion, Maya reparents child nodes before deleting them. - Refactor some common code to extract the list of UFE components from a trie node full path.
pierrebai-adsk
force-pushed
the
bailp/MAYA-127770/missing-discard-after-delete
branch
from
8805457 to
d02d2ec
Compare
AramAzhari-adsk
approved these changes
Jun 13, 2023
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After editing-as-Maya and then deleting the stage, the menu for discard edit would not show up or would do nothing. Fix this by correctly updating the pulled information on the Maya node.