Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-126029 - Implement experimental OCIO support #3153

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

JGamache-autodesk
Copy link
Collaborator

Uses information gathered from experimental Maya API to generate OCIO v2 color managed shader fragments. The implementation and textures are provided by the host. Some assembly required...

Uses information gathered from experimental Maya API to generate OCIO v2 color managed
shader fragments. The implementation and textures are provided by the
host. Some assembly required...
Copy link
Collaborator

@vlasovi vlasovi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. An autotest would be nice, but it can be added later

@JGamache-autodesk
Copy link
Collaborator Author

All the vp2renderDelegate autotests are color managed. Any mistake would have meant failures in the UsdPreviewSurface unit tests.

@vlasovi
Copy link
Collaborator

vlasovi commented Jun 12, 2023

Ok, good. Are all color management options currently covered with autotests?

@JGamache-autodesk
Copy link
Collaborator Author

A good test would require using an external OCIO config. I will definitely add that this week when I complete the MaterialX part of the work. I will make sure to have multiple complex cases in the same viewport to make sure LUTs are well managed and that the OCIO code fragments do not collide in the shader code.

@JGamache-autodesk
Copy link
Collaborator Author

JGamache-autodesk commented Jun 12, 2023

I used OCIO to create files with interesting color spaces and will use them in a unit test that will look like this:
image
Coming soon with the MaterialX implementation of OCIO.

Top line is Maya textures. Bottom line is UsdPreviewSurface. A third line will be added for MaterialX.

@JGamache-autodesk JGamache-autodesk added the ready-for-merge Development process is finished, PR is ready for merge label Jun 12, 2023
@JGamache-autodesk
Copy link
Collaborator Author

@seando-adsk Ready for merge. MaterialX support will be in a future PR.

@seando-adsk seando-adsk merged commit cd5c7ff into dev Jun 13, 2023
@seando-adsk seando-adsk deleted the gamaj/MAYA-126029/use_experimental_cm_api branch June 13, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge vp2renderdelegate Related to VP2RenderDelegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants