Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-129276 add payload #3151

Merged
merged 2 commits into from
Jun 15, 2023
Merged

MAYA-129276 add payload #3151

merged 2 commits into from
Jun 15, 2023

Conversation

pierrebai-adsk
Copy link
Collaborator

Code to add a payload:

  • Create add payload comand.
  • Handle prepend / append.
  • Handle loading or not the payload.
  • Add helper function to retrieve the add options: as ref/payload, prepend/append and preload-payload.
  • Add similar helpers in Python.

UI to add a payload:

  • Change label of context menu item.
  • Change title of the dialog.
  • Prepare file dialog layout code in Python.
  • Refactor common UI between Cache to USD and Add Ref/Payload
  • Change title of Cache to USD dialog as requested.
  • Change "As USD Reference" label to "Composition Arc".
  • Add optional "Load Payload" checkbox to UI.
  • Add the composition arc UI to the "Add reference/payload" UI.
  • Add all the event handling for the UI.

@pierrebai-adsk pierrebai-adsk added enhancement New feature or request adsk Related to Autodesk plugin labels Jun 8, 2023
@pierrebai-adsk pierrebai-adsk force-pushed the bailp/MAYA-129276/add-payload branch from ff3a115 to a13a76e Compare June 8, 2023 17:34
@pierrebai-adsk pierrebai-adsk force-pushed the bailp/MAYA-129276/add-payload branch from a13a76e to 592fd0a Compare June 8, 2023 18:40
Code to add a payload:
- Create add payload comand.
- Handle prepend / append.
- Handle loading or not the payload.
- Add helper function to retrieve the add options: as ref/payload, prepend/append and preload-payload.
- Add similar helpers in Python.

UI to add a payload:
- Change label of context menu item.
- Change title of the dialog.
- Prepare file dialog layout code in Python.
- Refactor common UI between Cache to USD and Add Ref/Payload
- Change title of Cache to USD dialog as requested.
- Change "As USD Reference" label to "Composition Arc".
- Add optional "Load Payload" checkbox to UI.
- Add the composition arc UI to the "Add reference/payload" UI.
- Add all the event handling for the UI.
vlasovi
vlasovi previously approved these changes Jun 12, 2023
Copy link
Collaborator

@vlasovi vlasovi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@pierrebai-adsk pierrebai-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Jun 12, 2023
Copy link
Collaborator

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks.

@seando-adsk seando-adsk merged commit da6b567 into dev Jun 15, 2023
@seando-adsk seando-adsk deleted the bailp/MAYA-129276/add-payload branch June 15, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adsk Related to Autodesk plugin enhancement New feature or request ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants