-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAYA-129276 add payload #3151
Merged
Merged
MAYA-129276 add payload #3151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ff3a115
to
a13a76e
Compare
a13a76e
to
592fd0a
Compare
Code to add a payload: - Create add payload comand. - Handle prepend / append. - Handle loading or not the payload. - Add helper function to retrieve the add options: as ref/payload, prepend/append and preload-payload. - Add similar helpers in Python. UI to add a payload: - Change label of context menu item. - Change title of the dialog. - Prepare file dialog layout code in Python. - Refactor common UI between Cache to USD and Add Ref/Payload - Change title of Cache to USD dialog as requested. - Change "As USD Reference" label to "Composition Arc". - Add optional "Load Payload" checkbox to UI. - Add the composition arc UI to the "Add reference/payload" UI. - Add all the event handling for the UI.
592fd0a
to
c45e813
Compare
vlasovi
previously approved these changes
Jun 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
AramAzhari-adsk
previously approved these changes
Jun 14, 2023
seando-adsk
reviewed
Jun 14, 2023
049c34e
vlasovi
approved these changes
Jun 14, 2023
seando-adsk
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
adsk
Related to Autodesk plugin
enhancement
New feature or request
ready-for-merge
Development process is finished, PR is ready for merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code to add a payload:
UI to add a payload: