MAYA-128907 fix layer parenting of relative layers #3141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a layers is saved as relative to its parent just before tryign to reparenting it to anotehr layer, the parenting would fail. That was because the layer identifier use inside the layer itself was relative, which prevented finding the layer afterward. The problem goes away when the stage is reloaded because when loading relative layers, it correctly set the lauer identifier to its absolute path. Fix the problem for recently-saved layers by making sure its identifier uses the absolute path, not the relative path.
vlasovi
approved these changes
Jun 6, 2023
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a layers is saved as relative to its parent just before tryign to reparenting it to anotehr layer, the parenting would fail. That was because the layer identifier use inside the layer itself was relative, which prevented finding the layer afterward.
The problem goes away when the stage is reloaded because when loading relative layers, it correctly set the lauer identifier to its absolute path.
Fix the problem for recently-saved layers by making sure its identifier uses the absolute path, not the relative path.