Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAYA-129309 fixing saving the pinned stage #3130

Merged
merged 1 commit into from
May 31, 2023
Merged

MAYA-129309 fixing saving the pinned stage #3130

merged 1 commit into from
May 31, 2023

Conversation

pierrebai-adsk
Copy link
Collaborator

  • Make the Maya session state resgister and unreguster its Maya notification on creation and deletion.
  • No longer de-regiuster the notifictions whne the layer manager window is created or closed.
  • That was causing the session state to not save the pinned stage because the layer manager would get destroyed before the pinned stage was saved and the notifications would no longer be received.
  • When switching pinned stage, mark the Maya scene as dirty.

@pierrebai-adsk
MAYA-129309 fixing saving the pinned stage
97ee907 
- Make the Maya session state resgister and unreguster its Maya notification on creation and deletion.
- No longer de-regiuster the notifictions whne the layer manager window is created or closed.
- That was causing the session state to not save the pinned stage because the layer manager would get destroyed before the pinned stage was saved and the notifications would no longer be received.
- When switching pinned stage, mark the Maya scene as dirty.
@pierrebai-adsk pierrebai-adsk added bug Something isn't working adsk Related to Autodesk plugin labels May 31, 2023
@pierrebai-adsk pierrebai-adsk requested a review from vlasovi May 31, 2023 15:26
vlasovi
vlasovi approved these changes May 31, 2023
View reviewed changes
Copy link
Collaborator

@vlasovi vlasovi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@pierrebai-adsk pierrebai-adsk added the ready-for-merge Development process is finished, PR is ready for merge label May 31, 2023
@seando-adsk seando-adsk merged commit 590ee8c into dev May 31, 2023
@seando-adsk seando-adsk deleted the bailp/MAYA-129309/pin-stage-dirty-scene branch May 31, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlasovi vlasovi vlasovi approved these changes

Assignees

@ecp-maya-devops-adsk ecp-maya-devops-adsk

Labels
adsk Related to Autodesk plugin bug Something isn't working ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pierrebai-adsk @vlasovi @seando-adsk @ecp-maya-devops-adsk