MAYA-129258 - MayaUsd: remove support for USD < v21.11 #3128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* cmake changes to remove old USD versions
* Code changes to remove USD versions < 21.11
* USD version is always at least 21.11 now.
| @@ -66,6 +66,7 @@ if(CMAKE_UFE_V2_FEATURES_AVAILABLE) | |||
| UsdUndoInsertChildCommand.cpp | |||
| UsdUndoReorderCommand.cpp | |||
| UsdUndoSetKindCommand.cpp | |||
| #UsdUndoMaterialCommands.cpp | |||
There was a problem hiding this comment.
Quick question. Seems like L202 to L208 are already commented out. Do we still need this file?
There was a problem hiding this comment.
Yes we still need this file. In another set of changes (different pull-request) I have removed all the commented lines.
samuelliu-adsk
approved these changes
Jun 5, 2023
seando-adsk
deleted the
donnels/MAYA-129258/remove_support_for_usd_less_than_21_11
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAYA-129258 - MayaUsd: remove support for USD < v21.11
Some notes about the changes: