MAYA-129141 - As a user, I'd like to set my anonymous layers as relative in Bulk Save's 'Save As' dialog #3104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrebai-adsk
approved these changes
May 18, 2023
vlasovi
added
the
ready-for-merge
|
@seando-adsk This PR can be merged now. The failing preflight is due to a known issue in testUsdExportPackage, which is not related to my changes. |
seando-adsk
reviewed
May 19, 2023
Comment on lines
+123
to
+127
| $titleCaption = "Save As"; | ||
| $actionCaption = "Save"; | ||
| } else { | ||
| $titleCaption = "Set As"; | ||
| $actionCaption = "Set"; |
There was a problem hiding this comment.
These strings should really be in resource dictionary for future translation. But actually these strings are probably already in one (or more) of the Maya dictionary files. Search for uses of uiRes and you can see how we can directly use a string from Maya.
There was a problem hiding this comment.
@seando-adsk If it's ok with you, I would have this PR merged as is and apply this change with my next PR, as there will be more changes going into Batch Save UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to bulk-save layers with relative paths