Recognize string properties with IsAssetIdentifier as being filename #2994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| retVal = Ufe::Attribute::kEnumString; | ||
| } else if (shaderProperty->IsAssetIdentifier()) { | ||
| retVal = Ufe::Attribute::kFilename; | ||
| } |
There was a problem hiding this comment.
Some 3rd party rendering engines can decide to keep "string" as the type of their asset ports. We can recognize them because they will have the asset flag enabled.
seando-adsk
reviewed
Mar 30, 2023
lib/mayaUsd/ufe/UsdAttribute.cpp
Outdated
| } | ||
|
|
||
| return std::string(); | ||
| } | ||
|
|
||
| void UsdAttributeFilename::set(const std::string& value) | ||
| { | ||
| SdfAssetPath path(value); | ||
| setUsdAttr<PXR_NS::SdfAssetPath>(*this, path); | ||
| if (UsdAttribute::nativeType() == "string") { |
There was a problem hiding this comment.
Ideally this should be the constant Ufe::Attribute::kString
There was a problem hiding this comment.
It would work, however nativeType is supposed to return a USD type as a string, so I have to use this longer constant that ends up having exactly the same value as Ufe::Attribute::kString.
There was a problem hiding this comment.
And instead of nativeType, I really should have used something that returns the true USD type. Fixed.
seando-adsk
added
ufe-usd
pierrebai-adsk
previously approved these changes
Mar 30, 2023
seando-adsk
approved these changes
Mar 31, 2023
JGamache-autodesk
added
the
ready-for-merge
pierrebai-adsk
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.