Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adhere to coding standard and use the fully qualified namespace name #2976

Merged
merged 2 commits into from
Mar 31, 2023
Merged

Adhere to coding standard and use the fully qualified namespace name #2976

merged 2 commits into from
Mar 31, 2023

Conversation

seando-adsk
Copy link
Collaborator

Recommended: to use fully qualified namespace names, unless clarity or readability is degraded by use of explicit namespaces, in which case a using directive is acceptable.

  • Replace "MayaUSD_NS_DEF/MAYAUSD_NS" with "MayaUsd"
  • Remove "using namespace MayaUsd"
  • Replace "using namespace PXR_NS" with "PXR_NAMESPACE_USING_DIRECTIVE"

@seando-adsk seando-adsk added the build Related to building maya-usd repository label Mar 28, 2023
pierrebai-adsk
pierrebai-adsk previously approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@pierrebai-adsk pierrebai-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work

@seando-adsk
Copy link
Collaborator Author

Windows test failure is the known random testUsdExportPackage failure.

@seando-adsk seando-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Mar 31, 2023
@seando-adsk seando-adsk merged commit 9995cdd into dev Mar 31, 2023
@seando-adsk seando-adsk deleted the donnels/use_proper_mayausd_namespace_name branch March 31, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierrebai-adsk pierrebai-adsk pierrebai-adsk left review comments

Assignees

@ecp-maya-devops-adsk ecp-maya-devops-adsk

Labels
build Related to building maya-usd repository ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seando-adsk @pierrebai-adsk @ecp-maya-devops-adsk