Add smart signaling for renderers. #2972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A renderer now only has to track the "updateid" and "resyncid" attributes of the stage to know if something significant happened. All UINodeGraphNodeAPI notifications were suppressed.
So client that do not care about resync can tune in only on update and get the expected results.
lib/mayaUsd/nodes/proxyShapeBase.cpp
Outdated
| } else if (it->IsPropertyPath()) { | ||
| // We have a bunch of UI properties to ignore. Especially anything that comes from UI | ||
| // schemas. | ||
| if (it->GetName().rfind("ui:", 0) == 0) { |
There was a problem hiding this comment.
If you refactor into another file, this code seems similar to code above. A helper function might be nice to abstract detecting UI fields.
pierrebai-adsk
previously approved these changes
Mar 27, 2023
pierrebai-adsk
approved these changes
Mar 27, 2023
|
Preflight error is a traditional |
JGamache-autodesk
added
the
ready-for-merge
|
@seando-adsk Ready for merge. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A renderer now only has to track the "updateid" and "resyncid" attributes of the stage to know if something significant happened.
All UINodeGraphNodeAPI notifications were suppressed.