Use "mtl" as default scope name on export #2903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This centralizes the declaration of the name and the two environment variable affecting it. It also exposes that name to the Python API for use in export scenarios. Unit tests that were relying on "Looks" had the USD_FORCE_DEFAULT_MATERIALS_SCOPE_NAME added to their environment when running.
JGamache-autodesk
requested review from
feldstj,
pierrebai-adsk and
seando-adsk
| @@ -797,8 +789,6 @@ global proc int mayaUsdTranslatorExport (string $parent, | |||
| $currentOptions = mayaUsdTranslatorExport_AppendJobContexts($currentOptions, "jobContext"); | |||
| } | |||
|
|
|||
| $currentOptions = mayaUsdTranslatorExport_AppendFromEnvElseDefault($currentOptions, "materialsScopeName", "MAYAUSD_MATERIALS_SCOPE_NAME", `getMayaUsdString("kExportMaterialsDefaultScopeName")`); | |||
|
|
|||
There was a problem hiding this comment.
No longer necessary.
|
|
||
| The `MAYAUSD_MATERIALS_SCOPE_NAME` environment variable can be used to change | ||
| that default on a global level. The value defined in that env var will take | ||
| precedence over any value passed in the materialsScopeName argument. |
There was a problem hiding this comment.
(Not sure I like that. Maybe this should override only when a materialsScopeName argument is not provided?)
pierrebai-adsk
approved these changes
Feb 27, 2023
feldstj
approved these changes
Feb 27, 2023
JGamache-autodesk
added
the
ready-for-merge
|
@seando-adsk Ready for merge. |
seando-adsk
approved these changes
Feb 28, 2023
seando-adsk
deleted the
gamaj/use_asset_wg_default_material_scope_name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This centralizes the declaration of the name and the two environment variable affecting it. It also exposes that name to the Python API for use in export scenarios.
Unit tests that were relying on "Looks" had the
USD_FORCE_DEFAULT_MATERIALS_SCOPE_NAME added to their environment when running.