Removed an artifical crash in transform operations and replaced it with a asserts. #2900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th a asserts. Fixes the crash when multiple instances of the same stage file are being rotated / scaled simultaneously.
|
For any other TF_Axiom that isn't directly resolving the issues in this particular jira, we'll have a separate task to refactor. |
pierrebai-adsk
approved these changes
Feb 24, 2023
| @@ -520,7 +520,7 @@ Ufe::ScaleUndoableCommand::Ptr UsdTransform3dMayaXformStack::scaleCmd(double x, | |||
| UsdGeomXformable xformable(usdSceneItem->prim()); | |||
|
|
|||
| auto s = xformable.AddScaleOp(UsdGeomXformOp::PrecisionFloat, opSuffix); | |||
| TF_AXIOM(s); | |||
| TF_VERIFY(s); | |||
There was a problem hiding this comment.
There are similar case for scale etc, for example line 687 (for some reason, github won't let me write this comment on line 687... seems we can only comment on modified lines!)
There was a problem hiding this comment.
Those are actually pivot commands. I've noticed any translation cmd such as translateCmd, translateRotatePivotCmd etc do not have any crash issues.
There was a problem hiding this comment.
I hate that github won't let you comment on unmodified lines!
seando-adsk
approved these changes
Feb 28, 2023
AramAzhari-adsk
added
the
ready-for-merge
seando-adsk
deleted the
azharia/MAYA-121916/multiple-instances-same-reference-transform-crashfix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the crash when multiple instances of the same stage file are being rotated / scaled simultaneously.