MAYA-127393 allow USD ref to be relative #2855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Jan 30, 2023
pierrebai-adsk
commented
- Refactor the Python helper to handle the relative-path UI in file dialogs.
- Make it more generic by abstracting to which file the path will be relative to, the label of the UI and the option var used.
- Add makePathRelativeTo function to UsdMayaUtilFileSystem to make any file path relative to a given directory.
- Add requireUsdPathsRelativeToEditTargetLayer function to verify if USD ref paths should be relative.
- Make the USD context menu use the new relative ref UI and functions.
- Refactor its code a bit to make reading the generated scripts easier.
- Refactor the Python helper to handle the relative-path UI in file dialogs. - Make it more generic by abstracting to which file the path will be relative to, the label of the UI and the option var used. - Add makePathRelativeTo function to UsdMayaUtilFileSystem to make any file path relative to a given directory. - Add requireUsdPathsRelativeToEditTargetLayer function to verify if USD ref paths should be relative. - Make the USD context menu use the new relative ref UI and functions. - Refactor its code a bit to make reading the generated scripts easier.
vlasovi
reviewed
Jan 30, 2023
vlasovi
previously approved these changes
Jan 30, 2023
seando-adsk
requested changes
Jan 30, 2023
- Remove unnecessary MEl scripts. - Call Python directly instead of through MEL. - Fix many comment typos. - Remove debug print statement.
vlasovi
previously approved these changes
Jan 30, 2023
The MString's isEmpty function does not exists in Maya 2022... use the length function instead.
Also, split the tool-tip on multiple lines for readability.
vlasovi
approved these changes
Feb 1, 2023
seando-adsk
reviewed
Feb 1, 2023
seando-adsk
approved these changes
Feb 1, 2023
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.