Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOOKDEVX-1091 - Add Ufe log on console to notify shader attribute without a default value #2823

Merged

Conversation

selvatm-autodesk
Copy link
Collaborator

@selvatm-autodesk selvatm-autodesk commented Jan 17, 2023

  • The goal is to notify the user when a property of any shader lacks a default value.
  • The properties that lack a default value will start to log a warning when the user interacts with them in the editor (that involves the get() of the property value).
  • Known attributes are maintained in a list (std::unordered_set) to avoid being too verbose for properties we have already printed on Console.

@selvatm-autodesk selvatm-autodesk added do-not-merge-yet Development is not finished, PR not ready for merge adsk Related to Autodesk plugin ufe-usd Related to UFE-USD plugin in Maya-Usd labels Jan 17, 2023
@selvatm-autodesk selvatm-autodesk force-pushed the selvatm/LOOKDEVX-1091/add-ufe-log-warning-no-default-value branch from 0671c25 to aaced77 Compare January 17, 2023 17:07
@selvatm-autodesk selvatm-autodesk removed the do-not-merge-yet Development is not finished, PR not ready for merge label Jan 17, 2023
@selvatm-autodesk selvatm-autodesk added the ready-for-merge Development process is finished, PR is ready for merge label Jan 18, 2023
@seando-adsk seando-adsk removed the ready-for-merge Development process is finished, PR is ready for merge label Jan 18, 2023
@selvatm-autodesk selvatm-autodesk added the ready-for-merge Development process is finished, PR is ready for merge label Jan 19, 2023
@seando-adsk seando-adsk merged commit 239a2c9 into dev Jan 19, 2023
@seando-adsk seando-adsk deleted the selvatm/LOOKDEVX-1091/add-ufe-log-warning-no-default-value branch January 19, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adsk Related to Autodesk plugin ready-for-merge Development process is finished, PR is ready for merge ufe-usd Related to UFE-USD plugin in Maya-Usd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants