MAYA-125036 correctly identify orphaned edited prims #2803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Provide a function to explicitly determine if an edited prim is orphaned. - Provide the function in Python too. - Use it both to build the context menu and do the outliner item rendering.
pierrebai-adsk
added
adsk
seando-adsk
requested changes
Jan 9, 2023
| @@ -117,6 +117,11 @@ std::string readPullInformationString(const PXR_NS::UsdPrim& prim) | |||
| return dagPathStr; | |||
| } | |||
|
|
|||
| bool isEditedPrimOrphaned(const PXR_NS::UsdPrim& prim) | |||
| { | |||
| return MAYAUSD_NS_DEF::isEditedAsMayaOrphaned(prim); | |||
There was a problem hiding this comment.
Just use the namespace name "MayaUsd::"
There was a problem hiding this comment.
I was using the same as existing code above it. I will change both.
| // pulled node and not some node that just happens to have the same | ||
| // name. This can happen, for example, when two variants each contain | ||
| // a child with the same name, one pulled, one not. | ||
| if (MAYAUSD_NS_DEF::isEditedAsMayaOrphaned(usdItemPath)) |
seando-adsk
approved these changes
Jan 9, 2023
pierrebai-adsk
added
the
ready-for-merge
|
@vlasovi Ivan can you please do a quick code review before I merge this. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes MAYA-126891