MAYA-124105 Fix opacity computations for MaterialX and USD materials #2790
Conversation
JGamache-autodesk
added
vp2renderdelegate
JGamache-autodesk
added
the
ready-for-merge
|
@vlasovi Ivan can you please code review this when you have time. Thanks. |
| @@ -145,7 +145,8 @@ class GlslGeneratorWrapperBase | |||
|
|
|||
| // Maya images require a texture coordinates to be flipped in V. | |||
| genOptions.fileTextureVerticalFlip = true; | |||
| genOptions.hwTransparency = mx::isTransparentSurface(_element, generator.getTarget()); | |||
| // Enabling hwTransparency to ensure a vec4 output with correct alpha value. | |||
| genOptions.hwTransparency = true; | |||
There was a problem hiding this comment.
@JGamache-autodesk What effect does this have? I just want to make sure we don't force opaque objects to be treated as transparent objects here.
There was a problem hiding this comment.
Setting it to false causes the fragment to return a color3 and then there is no alpha we can use if the shader is transparent.
Setting it to true forces it to always return a color4. The alpha channel will be set correctly and this will allow to turn transparency at the effect instance level.
There was a problem hiding this comment.
Allows us to re-use the same MaterialX OpenGL shader for both transparent and opaque shading.
|
@seando-adsk Ready for merge. |
No description provided.