Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty values for remapUVSetsTo #2784

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

dj-mcg
Copy link
Collaborator

@dj-mcg dj-mcg commented Dec 16, 2022

This fixes this test for environments with remapUVSetsTo defaults configured

This fixes this test for environments with remapUVSetsTo defaults
configured
@seando-adsk
Copy link
Collaborator

@dj-mcg Hi Dan, our devs have some comments/questions about this change.

Doesn't this change hide any problem that could happen with our default values by never letting them be tested?

This change is not problematic for us, but raises the question about accommodating users with custom environments that override default values.

Where is "remapUVSetsTo" default getting modified? Is it a custom plugin you are using internally?

@dj-mcg
Copy link
Collaborator Author

dj-mcg commented Jan 3, 2023

Yes, we're defining studio specific defaults for import and export behavior in a plugin, so this test fails for us unless we explicitly override it with an empty stringPairVector mapping. Simply passing an empty list falls back to whatever default is defined by the runtime environment. If an empty list is intended to override custom defaults, we may have to change how the userArgs are parsed in jobArgs.cpp

@seando-adsk seando-adsk added unit test Related to unit tests (both python or c++) ready-for-merge Development process is finished, PR is ready for merge labels Jan 25, 2023
@seando-adsk seando-adsk merged commit f3f53b5 into Autodesk:dev Jan 25, 2023
@dj-mcg dj-mcg deleted the pr/Fix_UV_Export_Test branch January 25, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge unit test Related to unit tests (both python or c++)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants