-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export Normals by default and modify docs to match code behaviour #2768
Conversation
…nt. Fix the doc to match the behaviour of the repo instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine and simple.
@dgovil Can you have a look at testUsdExportMesh as it failed. The original change #2713 modified the scene file (.ma). Do we need an update to that file again here or an update to the test?
|
@seando-adsk ah my bad, I'd reverted the file but forgotten to add it to the commit. Updated the PR now. |
@dj-mcg Are you okay with this change? |
In an ideal world we'd be able to fix the behavior to match the docs, since that's what was originally intended and expected within Pixar. However, this has been out in the wild for a while, and a change like this will impact other folks now reliant on this (incorrect) default export behavior. So, I understand @dgovil's position here, and I'm ok to address this on our side if you guys are fine with accepting it. |
I confirm having this issue on 0.21.0, it's a serious breaking change for our use case (automatic export of car models coming from nurb surfaces). We're reverting back to 0.20.0 for now until the normal behavior comes back in a later version. Thanks @dgovil for pointing this out. @dj-mcg we're open to re-adapte our pipeline of course if this subject comes back, but in that case a deprecation warning in an intermediary version would be ideal I think. |
This PR addresses #2767 which was an issue caused from a change in #2713
While I understand that #2713 was done to make the behavior of the plugin match what the doc says, I think the inverse should have happened: the doc should have been updated to match what the code has been doing in production for multiple years now.
So this change reverts the default for exportNormals when subdiv Schema is not set to True, and then updates the document to match the behaviour.
Without this PR, it would require everyone to modify their pre-existing Maya files to get normal export working, and any new meshes would require an extra step of adding a custom attribute before they get normals in their export.
Without normals being exported, many meshes being exported out of Maya are showing up broken in real time renderers that don't apply subdivision. For example, all meshes being exported would be broken when viewed with RealityKit or QuickLook on iOS, because the user authored normals aren't present.