Test if visibility edit is valid before returning command. #2725
Conversation
|
|
||
| UsdGeomImageable primImageable(prim); | ||
|
|
||
| EditTargetGuard guard(prim, layer); | ||
|
|
||
| std::string errMsg; | ||
| if (!MayaUsd::ufe::isAttributeEditAllowed(primImageable.GetVisibilityAttr(), &errMsg)) { |
There was a problem hiding this comment.
Perform the edit check on command creation, rather than execution. Failure on execution should be reported through an exception, but here the check really belongs to command creation: we communicate to the caller that the operation is not possible by returning a nullptr.
Furthermore, the edit guard must be set before performing the check, otherwise the check will be done on the current target, then the edit guard changes that target. In the case of an existing visibility edit in the session layer, this would mean that the check would be done on the current edit target layer, which typically is lower priority than the session layer, and the edit would fail. If the check is done when the edit target guard is set, the check properly occurs on the session layer. This accounts for many of the failures described in
ppt-adsk
added
the
ready-for-merge
No description provided.