MAYA-125038 serialization of pull variant info into JSON #2682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Oct 26, 2022
pierrebai-adsk
commented
- Conversion to and from JSON
- Save and restore the orphaned nodes manager state
- Register unregister callbacks on construction, unregister on destruction of the prim updater manager.
- Add after new / open callback to load the orphaned nodes manager state.
- Add before save callback to save the orphnaed nodes manager state.
- Move generic JSON function to their own file under mayaUsd/utils.
- Improve the dynamic attribute functions to use C++ API instead of MEL.
- Add unit test
- Conversion to and from JSON - Save and restore the orphaned nodes manager state - Register unregister callbacks on construction, unregister on destruction of the prim updater manager. - Add after new / open callback to load the orphaned nodes manager state. - Add before save callback to save the orphnaed nodes manager state. - Move generic JSON function to their own file under mayaUsd/utils. - Improve the dynamic attribute functions to use C++ API instead of MEL. - Add unit test
pierrebai-adsk
commented
Oct 26, 2022
| { | ||
| return Memento(deepCopy(pulledPrims())); | ||
| } | ||
|
|
There was a problem hiding this comment.
The refactor of the code that create a Memento into a public function is necessary to be able to save and restore the orphaned nodes manager when saving and loading a Maya scene.
pierrebai-adsk
commented
Oct 26, 2022
| PullVariantInfo(const MDagPath& dp, const std::list<VariantSetDescriptor>& vsd) | ||
| : dagPath(dp) | ||
| PullVariantInfo(const MDagPath& pulledParent, const std::list<VariantSetDescriptor>& vsd) | ||
| : pulledParentPath(pulledParent) |
There was a problem hiding this comment.
Rname dagPath to pulledParentPath to make the code easier to understand. It is also necessary because subsequent change in other PR adds other MDagPath and the generic name rapidly became a hindrance.
pierrebai-adsk
commented
Oct 26, 2022
| class OrphanedNodesManager : public Ufe::Observer | ||
| { | ||
| public: | ||
| /// \brief Records a single variant selection of a single variant set. |
There was a problem hiding this comment.
Had to make the data structure public so that the code that save and restore the state can access them.
pierrebai-adsk
commented
Nov 7, 2022
| cmds.file(filename, open=True) | ||
|
|
||
| def testHideOnNestedVariantSwitchOnReload(self): | ||
| # Pull on C and E. |
There was a problem hiding this comment.
This new test tests the JSON code at the same time since it saves and reload the orphaned nodes manager using them.
ppt-adsk
approved these changes
Nov 7, 2022
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
approved these changes
Nov 9, 2022
seando-adsk
deleted the
bailp/MAYA-125038/pull-variants-tracking-persistence
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.