Use Adapter to author MeshLightAPI for RfM's PxrMeshLight #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also apply gamma correction to color values on RfM lights
|
Shoot it looks like the meshLightAPI is just slightly too new for this to go in without version guards. |
Restore MeshLight-as-Prim export for older versions of Usd that predate the introduction of the MeshLightAPI
Remove inline ifdefs and just exclude it from the build
|
Hi @seando-adsk - this is an attempt to use the existing adapters to author out a MeshLightAPI on export. Note that we didn't add import steps as they were not needed at Pixar, and unfortunately we are a bit overloaded on production-facing tasks. Despite this I'd love to integrate this into the codebase since the code spans several files and will likely cause merge conflicts going forward if we keep patching it on top. Thanks! |
JGamache-autodesk
approved these changes
Sep 21, 2022
seando-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also apply gamma correction to color values on RfM lights