MAYA-124820: When adding an Xform to a USD prim two entries are shown… #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the channel box * Restore Attribute cache for USD attributes which don't change.
seando-adsk
commented
Aug 24, 2022
Comment on lines
+262
to
+265
| // If this is a Usd attribute (cannot change) then we cache it for future access. | ||
| if (!canRemoveAttribute(fItem, name)) { | ||
| fUsdAttributes[name] = newAttr; | ||
| } |
There was a problem hiding this comment.
Restored the USD attribute cache, but only for attributes which do not change.
JGamache-autodesk
previously approved these changes
Aug 24, 2022
ppt-adsk
previously approved these changes
Aug 25, 2022
… in the channel box * Handle attribute cache differently depending on Ufe version.
seando-adsk
dismissed stale reviews from ppt-adsk and JGamache-autodesk
via
335139c
ppt-adsk
approved these changes
Aug 30, 2022
seando-adsk
added
the
ready-for-merge
seando-adsk
deleted the
donnels/MAYA-124820/restore_usd_attribute_cache
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAYA-124820: When adding an Xform to a USD prim two entries are shown in the channel box