Undo of delete must update stage cache. #2503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrebai-adsk
previously approved these changes
Jul 26, 2022
lib/mayaUsd/ufe/UsdStageMap.cpp
Outdated
| @@ -83,6 +86,16 @@ inline Ufe::Path::Segments::size_type nbPathSegments(const Ufe::Path& path) | |||
| #endif | |||
| } | |||
|
|
|||
| inline Ufe::Path toPath(const std::string& pathString) | |||
There was a problem hiding this comment.
I almost feel like we should put this in some util function, it has come up a few times in the past... I know I've been bitten a lot by it in unit test (but that is in Python, irrelevant here.)
pierrebai-adsk
previously approved these changes
Jul 26, 2022
|
Assigned the Jira ticket to you so you can resolve it to QA when the tests pass. |
ppt-adsk
commented
Jul 27, 2022
| @@ -147,6 +147,53 @@ def testDeleteStage(self): | |||
| # Request the now dead proxy shape. This should not crash. | |||
| result = handler.findGatewayItems(proxyShapePath) | |||
|
|
|||
| @unittest.skipUnless(ufeUtils.ufeFeatureSetVersion() >= 2, 'testDeleteStageUndo uses PathString which is only available in UFE v2 or greater.') | |||
There was a problem hiding this comment.
Thanks to @pierrebai-adsk for the test.
pierrebai-adsk
approved these changes
Jul 27, 2022
ppt-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.